Zakhar Zibarov <[email protected]> writes: > Can anybody review this patch and apply it to main repo?
[looks like this is urgent for you. please give us a bit more time for your next patch] Here's my code review: 1. can you get rid of whitespace changes to unrelated lines in your patch? 2. Can you fix the following issue (i.e. please attach your patch, do no send it inline or copy&paste it). ,---- | [py27] [git:master] ~/code/ % patch -p1 <patch | patching file mwlib/templ/magic_time.py | patch: **** malformed patch at line 63: datetime.datetime.now().replace(hour=int(datestring[:2]), `---- 3. the testcases only cover xr, the regular expression seems to imply that xn and xN also have a special meaning. Can you add testcases for those? 4. Can you add testcases for the xr"foobar" case. 5. Can you get rid of the catch all "except:" Thanks for your help, - Ralf -- You received this message because you are subscribed to the Google Groups "mwlib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/mwlib?hl=en.
