Follow-up Comment #5, bug #17907 (project mypaint):

Almost there:
- You're removing the scrolledwindow that was there before. Don't do that.
Add all the expanders to a new vbox, and pack this in the scrolledwindow.
- The patch adds a member variable. Please move the initialization to
__init__() and explain what it does/why it exists there.
- The patch adds a #FIXME comment. Only do that when you're sure it makes
sense to do so. And when you do, make sure it is something understandable to
others (including you 10 months from now).
- Please follow our style guidelines for commit message
- Your patch introduces some whitespace errors, please fix that

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?17907>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Mypaint-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/mypaint-bugs

Reply via email to