Follow-up Comment #4, bug #20359 (project mypaint):
I submitted about groups to the mailing list. Sorry, didn't know it was on
forums. Now it on three places.
Well, from what I gathered playing about month
1) Moving single layer as is, then moving children in finalizer works fine.
(in my fork on gitorium there are no groups per se, but layers are linked by
name and can have child layers)
I'm actually not sure that moving all layers in dran'n'drop is a good idea:
moving one single layer 1500x2500 is shaky already so I can clearly see tiles.
Moving ten of them probably would be nightmare.
Maybe add translate_x, translate_y into Layer, use it to render layer and
perform actual movement in finalizer of LayerMoveMode?
(Though honestly I didn't figure out yet where layers are actually being
rendered and if it possible to translate their rendering without huge work)
2) Changing opacity is simple to implement already(I did it in fork). You need
only to modify effective_opacity to multiply opacity it by effective_opacity
of parent. (It's probably wise idea to cache multiplier, but that's not the
point)
3) I'm not sure about layer group visibility.
Very often I want to disable visibility of the whole group, but leave one
layer visible(like Home key, but for group). Personally I think that
visibility should be determined as follows:
1) If layer is not visible, do not do not display layer
2) If parent group is not visible, do not display layer
3) Ignore parent group visibility if layer is visible and this setting was
done later then parent's visibility.
E.g. we have group G, and inside layers L1, L2, L3.
We
* turn off visibility of L1: it became invisible,
* turn it on: L1 became visible
* turn off G: L1, L2, L3 became invisible
* turn visible on L2: it became visible because even though its group
invisible, its own visibility setting was set after group visibility and
therefore overrides it.
What do you think about this approach?
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?20359>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Mypaint-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/mypaint-bugs
