On 12 September 2010 14:21, Vasilis Platanias <[email protected]> wrote: >> There are several things you should fix with this patch: >> - follow the conventions of the file you are editing >> (whitespace, explicit coding of float constants) >> - tell git your email >> - patches are prefered plain text, not .tar.gz >> - when hitting "warmer" many times, it should not cycle forth/back between >> two colors in the end, but stick at the same color. >> - I think steps for cooler/warmer are a bit tiny, 0.02 might work better? > > Done, and done. I've set the step to 0.15, but feel free to change it > to a bigger step if you think it's still too small. > Ideally, it should vary depending on the current hue, but that's a bit > overcomplicated. > I've also added a small margin (+- 0.01 or +- 3) to stop cycling > between two colors at the warmest and coolest points. This has the > drawback that once that value is reached, warm and cool actions stop > working.. Maybe that's correct though. >
I find it very confusing that once the warmest point has been reached, I cannot use the "colder" action again. And visa versa. A minor point is that I think I'd prefer separators in the menu so that the two inverse actions are grouped together. Also, the patch adds trailing whitespace in several places, please avoid that. -- Regards Jon Nordby - www.jonnor.com _______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
