Thanks for the update. If you squash commits, please do attribution for work done by someone else in the commit message. The copyright note at the top of every file would get quite a burden if it was updated with every contributor's name.
I did some 'git rebase -i' and 'git cherry-pick' to show what I mean, but I'm also happy if you just state it in the commit message: https://gitorious.org/~maxy/mypaint/maxy-experimental/commits/linemode Your updated branch contains new code (I think it's only the "curve widget" patch from David Gowers). I like the idea of manipulating the shape that way, but I'm not convinced about the implementation yet. I was just trying it quickly, and it has some obvious glitches: 1. When you drag a point over the border of the line of the widget (which is easy to do accidentally), the widget disappears before you release the click. And when you open it the next time, you are still dragging the point around. 2. The tooltip is too big and tends to get into the way, at least when using the mouse. I would be very surprised if users did actually bother read it unless they get really desperate. If the curve was labeled "Line Pressure" instead of "Line Shape", the tooltip would be almost unnecessary - it's quite inuitive IMO. If there is a tooltip, I suggest to make it only over the label, not the whole widget. I'm also sceptical about subclassing CurveWidget. By subclassing it, you have to duplicate the code in motion_notify_cb(). This is almost guaranteed to get out of sync if anyone ever makes a change. I think the better approach, from a maintainer's point of view, would be to add the new functionality to the original CurveWidget. It was already done like that when re-using the widget for the global pressure preferences (self.magnetic), and it could be done like that again (just make the ylock part of the normal widget, and add self.fixed_number_of_points or similar). Regards Martin On Sat, Feb 18, 2012 at 11:26:29AM -0500, Richard Jones wrote: > Thanks! > Branch has been updated. > https://gitorious.org/~optigon/mypaint/optigon-mypaint/commits/rj/linemode > > On Sat, Feb 18, 2012 at 1:22 AM, David Gowers (kampu) <[email protected]>wrote: > > > On Sat, Feb 18, 2012 at 2:42 PM, Richard Jones <[email protected]> > > wrote: > > > I changed the "unpythonic" code to use getattr, but now the menu xml has > > > lower case headings... is this okay? > > > > You can have both correct -- str.lower() (as in actionname.lower()) is > > your friend here :) > > > _______________________________________________ > Mypaint-discuss mailing list > [email protected] > https://mail.gna.org/listinfo/mypaint-discuss -- Martin Renold _______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
