Looks good to me, I pushed it to master. On Mon, Jan 07, 2013 at 04:55:05AM +0000, Micael wrote: > Ok, I've implemented snap-to-pixel as a brush setting. It is now > possible to get 1 pixel wide brushes, so the pixel brush works fine > now. > https://gitorious.org/~mdias/mypaint/mdiass-mypaint > > Single dabs' shapes are also quiet predictable when full snapping is > on, instead of slightly randomized, which may be useful in some > special situation. > > The code actually snaps 2 slightly different things; the actual dab's > position, and the dab's radius. I'm currently using only one setting > for both, as I'm not sure if there could be a need to snap the brush's > center and the radius separately. It's a pretty simple thing to add, I > just don't want to carelessly add new settings... > > On Mon, Jan 7, 2013 at 1:29 AM, Micael <[email protected]> wrote: > > Thank you. > > > > I'm not very happy with the boolean commit either, specially since it > > doesn't solve the problem without introducing other problems. I think > > I have an idea on how to make it work with a single float value - > > brush-configurable - that will enable linear interpolation between > > no-aa and aa-approximation, and I will try to make it work ASAP, as > > well as adding an appropriate description to the new setting. > > > > Regardless of this change I purpose renaming the current > > "antialiasing" field to "feather" though; I believe that's much more > > appropriate and artists are already familiar with that term and what > > it does. > > > > On Sun, Jan 6, 2013 at 5:11 PM, Martin Renold <[email protected]> wrote: > >> I have rebased and pushed the first two of your commits into master. Let's > >> build on that. > >> > >> Not sure if I'm happy yet with the last commit (the boolean). Are you > >> working on a different approach? Also, strings are not frozen any more, it > >> would be nice to have some explanation in the brushsetting tooltips > >> (brushsettings.json) about what's actually having what effect now. > >> > >> On Sun, Dec 16, 2012 at 07:26:49PM +0000, [email protected] wrote: > >>> We can surely make snapping a slider which will basically lerp between > >>> snapped and non-snapped, but we still need something that will > >>> enable/disable the new aa algorithm, otherwise pixel-sharp dabs won't be > >>> possible, and the current workaround (aa=0 is no-aa, aa=0.001 is normal > >>> aa with little feather) is asking to confuse users IMO. > >>> > >>> > >>> On 16/12/12 16:23 Martin Renold wrote: > >>> > >>> On Sun, Dec 16, 2012 at 02:38:09PM +0000, Micael wrote: > >>> > > >>> > Maybe we should create a new slider for enabling/disabling the > >>> > AA+snapping > >>> > (<0.5 is disabled, >=0.5 is enabled) for now while we don't have the > >>> > ability to create checkboxes? > >>> > >>> > >>> I don't see the lack of checkboxes as a limitation, it's more an > >>> encouragement to create smooth brushsettings that can be mapped to any > >>> input > >>> without creating glitches. Actually it's not so hard to think of something > >>> between fully snapping to integer pixels and not snapping at all. If this > >>> seems all too complicated, at the very least we can make in-between values > >>> stand for the per-dab probability to snap. > >>> > >>> -- > >>> > >>> Martin Renold > >>> > >>> > >>> > >> > >> -- > >> Martin Renold > > > > > > > > -- > > Micael Dias > > > > -- > Micael Dias >
-- Martin Renold _______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
