Hi Jon, On Sun, Jul 13, 2014 at 4:30 PM, Jon Nordby <[email protected]> wrote: > Hi Jehan, > I responded on the pull request. > https://github.com/mypaint/libmypaint/pull/3
Answered there too. I removed the restructuration commit. Just left the 2 bug fixes. Jehan > > > On 13 July 2014 15:13, Jehan Pagès <[email protected]> wrote: >> >> Hi, >> >> I'm a GIMP dev. We may have met in LGM. Anyway I submitted a pull >> request on your github instance. >> >> 1/ The first commit is a one-liner bug (but still important because it >> was breaking compilation of GIMP on linking). I guess there is not >> much to discuss about it. >> >> 2/ The second commit (I wish github allowed me to make a separate pull >> request for it, but apparently it won't) is a request for change. >> Right now your CFLAGS is Cflags: -I${includedir}/lib@LIBNAME@ >> It makes that we have to #include "mypaint-brush.h". I believe this >> would be cleaner to #include "libmypaint/mypaint-brush.h" (which may >> work "by chance" if you installed libmypaint in the same prefix as >> other libs, but is not guaranteed). This way, we immediately see in a >> glimpse where an include comes from. Of course, you could say there is >> the "mypaint-" in the start of the file name, but then what about: >> #include "glib/mypaint-brush.h" >> Looks like a glib include! >> On the other hand, #include "libmypaint/glib/mypaint-brush.h" would be >> nicer in my opinion. >> >> Of course, that's a matter of choice and preference, not a bug. So >> that's up to you to decide whether you agree to this change. And we'll >> update GIMP accordingly. >> The first commit though, that would be nice if you could merge it. :-) >> Thanks! >> >> Jehan >> >> _______________________________________________ >> Mypaint-discuss mailing list >> [email protected] >> https://mail.gna.org/listinfo/mypaint-discuss > > > > > -- > Jon Nordby - www.jonnor.com _______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
