Author: wyoung
Date: Fri Aug  3 22:06:49 2007
New Revision: 1735

URL: http://svn.gna.org/viewcvs/mysqlpp?rev=1735&view=rev
Log:
test_manip now passes all tests.  Earlier notion that these tests should
fail and the library needs changing was wrong.  There are tests we could
write that should fail and which will pass when the proposed manipulator
changes are made, but these are not those.

Modified:
    trunk/test/test_manip.cpp

Modified: trunk/test/test_manip.cpp
URL: 
http://svn.gna.org/viewcvs/mysqlpp/trunk/test/test_manip.cpp?rev=1735&r1=1734&r2=1735&view=diff
==============================================================================
--- trunk/test/test_manip.cpp (original)
+++ trunk/test/test_manip.cpp Fri Aug  3 22:06:49 2007
@@ -79,14 +79,17 @@
 }
 
 
-// Stringish types should be implicitly quoted when inserted into Query
+// The only stringish type that should be implicitly quoted when
+// inserted into Query is ColData, and not always then; we don't know
+// enough about anything else to make good automated choices.
 template <class T>
 static bool
 test_implicit_query_quote(mysqlpp::Query& q, T test, size_t len)
 {
        q.reset();
        q << test;
-       if (is_quoted(q.str(), test, len)) {
+       if (is_quoted(q.str(), test, len) || 
+                       (typeid(test) != typeid(mysqlpp::ColData))) {
                return true;
        }
        else {


_______________________________________________
Mysqlpp-commits mailing list
[email protected]
https://mail.gna.org/listinfo/mysqlpp-commits

Reply via email to