On Saturday 11 December 2004 12:09 pm, Colin Guthrie wrote: > Just a small patch to myth music. > > It fixes a segfault in the ripping of oggs that I introduced with my > metadata patch (sorry!). It was due to my changes to vorbisencoder and > the use of a pointer rather than a stack member variable. I don't know > why it was causing problems but it wasy. I took a look and there was no > reason to do it like this, so I just changed it back to the way it was > and pass a pointer into my function with an & prefix instead. > > Also use the fdopen function rather than the silly way I was doing it in > the metaiooggvorbiscomment.cpp file for the creation of a temporary > file. This particular bit of code is not currently in use anyway hense > why I didn't bother supplying the patch until I had a reason to do > something else too! > > > This should be trivial if someone with cvs write access can apply it.
I've applied this to CVS. Isaac _______________________________________________ mythtv-dev mailing list [email protected] http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
