Isaac Richards wrote:
On Friday 31 December 2004 05:30 pm, John Patrick Poet wrote:
Found a race condition which could cause a segfault. Could have sworn I
already fixed this, but it was not in the patch I submitted on Dec 30th.
Isaac, this patch is a replacement for the previous one I submitted. If
you want a diff between the previous one and this one, let me know.
Won't need one - haven't started applying patches yet.
Isaac
Arg! Maybe I should not post fixes to patches when I have a head cold.
The "fix" in v1.0a has inverted logic. Here is a patch to fix it.
Sorry Isaac. I see you have already commit 1.0a.
John
Index: libs/libmythtv/dtvrecorder.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/dtvrecorder.cpp,v
retrieving revision 1.3
diff -d -u -r1.3 dtvrecorder.cpp
--- libs/libmythtv/dtvrecorder.cpp 1 Jan 2005 06:16:17 -0000 1.3
+++ libs/libmythtv/dtvrecorder.cpp 1 Jan 2005 10:48:04 -0000
@@ -68,6 +68,9 @@
{
// Better to have a memory leak, then a segfault?
VERBOSE(VB_IMPORTANT, "DTV ringbuffer not cleaned up!\n");
+ }
+ else
+ {
delete[] ringbuf.buffer;
ringbuf.buffer = 0;
}
_______________________________________________
mythtv-dev mailing list
[email protected]
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
