Chris Pinkham wrote:
This patch updates the playlist UI with feedback from Chris Pinkham. It
does the following:
Thanks for taking care of this. Looks great.
I've applied the patch to current CVS after a couple minor mods. I had
to change the argument to ScheduledRecording::signalChange() which should
be a number and you were passing in a QSqlDatabase::database(). Not sure
how that even compiled. :) I also changed a few lines that were over 80
characters long, and I added a togglePlayListTitle(void) method. With all
the work you did, I noticed one last thing that could be confusing to the
user. If you hit INFO while on the left hand title box and selected
"Add To Playlist", the info displaying was for a specific recording, but
the whole title/group/etc. would be added to the playlist since
togglePlayListItem(void) was just checking "if (inTitle)" when it determined
whether to add the individual recording or the whole group. It wasn't
checking to see where it was called from. So, I made a new SLOT that is
called for the buttons that say they are going to affect all items in
the title/group and used the original togglePlayListItem slot for the
INFO popup menu and for the MENU popup when the focus is on a specific
recording using the same checks you have to display different text
on the button depending on the values of inTitle and titleView.
You'll probably have to un-apply your patch before syncing with CVS since
I changed a few things. Can you re-update and make sure you think the
changes for the INFO popup's "Add to Playlist"/"Remove from Playlist"
button makes sense? I just thought it was kind of confusing when I was
on a Title and hit INFO and it popped up the INFO menu, but when I hit
"Add to Playlist", instead of adding just the recording who's information
was on the INFO menu, it instead added all recordings for that title.
I can probably check that tonight. The signal change was because I'm
working on a CVS from a few days ago and not the latest (haven't updated
as I was waiting until the patches all came through for the impending
release). Your changes should completely reasonable. I didn't recall
that hitting INFO while on the title list on the left did anything at
all so I certainly hadn't tested that case. I'll take a look tonight
and let you know if there is anything I see that needs adjusting.
Kevin
_______________________________________________
mythtv-dev mailing list
[email protected]
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
