Isaac Richards wrote:
On Saturday 05 February 2005 09:05 am, Colin Guthrie wrote:

OK I was lying... my .cvsrc had loads of weird diff options... No idea
why they are there.... weird.

Anyways, I've regenerated and attached.


I'll apply this (and fix the dbcheck stuff because of the smartplaylist patch), but I need the metaiovorbiscomment.h file you added but didn't include in the patch.

Great. I can't believe I missed this file out too. I'm a muppet!

I've attached a new patch and the file itself, so take your pick.

The new patch is from today's CVS and has the dbcheck stuff altered (as
the smart playlist was commited in the interim) and also fixes conflicts
in editmetadata.cpp (as I've changed the style of this).

My only concern is the change to the file music-ui.xml for the edit
metadata dialog. I don't know how to propigate these changes to other
themes etc.

I'm guessing it should just be a copy/paste job as other themes prob.
don't do anything with this dialog yet. (fingers crossed)

If I get the chance, I'll update the docs accordingly before you cut it.

All the best

Col.


--

+------------------------+
|     Colin Guthrie      |
+------------------------+
|   [EMAIL PROTECTED]  |
| http://colin.guthr.ie/ |
+------------------------+

Attachment: compilation_artist.diff.bz2
Description: BZip2 compressed data

// Defines of the tag names used in vorbis comments

#define MYTH_VORBISCOMMENT_ARTIST                    "ARTIST"
#define MYTH_VORBISCOMMENT_TITLE                     "TITLE"
#define MYTH_VORBISCOMMENT_ALBUM                     "ALBUM"
#define MYTH_VORBISCOMMENT_GENRE                     "GENRE"
#define MYTH_VORBISCOMMENT_DATE                      "DATE"
#define MYTH_VORBISCOMMENT_TRACK                     "TRACKNUMBER"
#define MYTH_VORBISCOMMENT_COMPILATIONARTIST         "COMPILATION_ARTIST"
#define MYTH_VORBISCOMMENT_MUSICBRAINZ_ALBUMARTISTID "MUSICBRAINZ_ALBUMARTISTID"

_______________________________________________
mythtv-dev mailing list
[email protected]
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Reply via email to