On Sun, Feb 20, 2005 at 03:22:50PM -0500, J. Donavan Stanley wrote: > Mark Anderson wrote: > > >I don't believe the code actually knows the number of channels in the > >ac3 so it can't apply the channels test to ac3. It **should** select > >the "first" ac3 track, or the MPEG track with the highest number of > >channels. As I mentioned in my reply to your [users] post, the count > >up seems to be the right way, but I am still concerned that I don't > >understand why the original author wrote the loop as a count down. > >There must have been a reason right? I don't have my myth box handy > >so I can't look into it at the momement. > > > As I've said in previous threads. Picking the first track that fit the > requirements was the wrong choice for the various perfect DVD rips I had > on my machine, which is why the ability to select tracks was added in > the first place.
Can you tell me a bit about what the streams looked like on your DVD rips? How many AC-3 streams and what parameters were available from them? (At the very least, for now, you might alter the comments so they don't disagree with the code -- the comment says it picks the first track, but the code counts down and picks the last track.) The 3 AC-3 streams on KQED/PBS are rather odd. For the particular Nova I recorded, the first stream had sound for the show and also the surrounding non-show announcements and snippets of the preceding and trailing show. The second stream, though it had a lower bitrate, had the sound for the Nova show but NOT for the announcements and other shows before and after. It was also louder! The third stream (unfortunately the one chosen by the current CVS code) seems completely silent. It would not be hard to make code that, for example, picked the AC-3 stream with the highest bitrate, which would be the first stream in the example above but who knows what else there is out there. I must say that my personal view would be that if you had to choose between being right on DVDs and right on broadcast TV, I would pick the latter because by default the internal player doesn't play the videos, and people watching dvds are more used to having multiple soundtracks. However, we don't really know what sort of patterns we will see from broadcast, if kqed is normal or an anomaly, etc. So if people have samples of the parameters of multiple streams from dvds and broadcast shows, let's post them and look for a pattern.
_______________________________________________ mythtv-dev mailing list mythtv-dev@mythtv.org http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
