tommy wrote:
Isaac Richards wrote:
On Tuesday 28 December 2004 01:37 am, tommy wrote:
The pointer manipulation in the two lines of code are incorrect for k8 processors, they were causing the frontend to segfault on playback. This hasn't been tested on a 32 bit processor, so if someone could make sure it compiles without warnings and works that would be great.
Can someone test this so I can commit it? My pvr-350 using machine isn't booting at the moment..
Isaac
I finally managed to test this patch on my mates Athlon XP 3200 and PVR-350 tonight with the latest cvs, the patch still applies cleanly and he seems happy with the playback over his PVR-350.
Just a little curious as to why this patch hasn't been applied yet? Is there something wrong with it?
I have a feeling with the automagic settings.pro in cvs automatically building for k8 processors this will come up as a problem in the near furture.
Cheers, Tom.
Index: libs/libmythtv/videoout_ivtv.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/videoout_ivtv.cpp,v
retrieving revision 1.36
diff -u -r1.36 videoout_ivtv.cpp
--- libs/libmythtv/videoout_ivtv.cpp 12 Nov 2004 01:17:22 -0000 1.36
+++ libs/libmythtv/videoout_ivtv.cpp 28 Dec 2004 06:30:09 -0000
@@ -202,8 +202,8 @@
long pagesize = sysconf(_SC_PAGE_SIZE);
long pagemask = ~(pagesize-1);
osdbuffer = new char[osdbufsize + pagesize];
- osdbuf_aligned = (char *)((int)osdbuffer + (pagesize - 1));
- osdbuf_aligned = (char *)((int)osdbuf_aligned & pagemask);
+ osdbuf_aligned = osdbuffer + (pagesize - 1);
+ osdbuf_aligned = (char *)((unsigned long)osdbuf_aligned & pagemask);
memset(osdbuf_aligned, 0x00, osdbufsize);
_______________________________________________ mythtv-dev mailing list [email protected] http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
