David Engel wrote:

Colin, I have a few questions/issues regarding this change.

1. How hard would it have been to not delete the relevant info from
  the original tables if a recording was still present?



It wouldn't be hard, but I chose to do it this way because I've always considered the program table to be volatile data that was easily regenerated, so I sometimes empty the table. This way, the irreplacable data is seperated from the replacable data.

2. The starttime in the recorded table is the time the recording was
  started, not the starttime from the program table.  So, if a
  program starts recording early or late, I don't think the info in
  the new tables will be available.



I noticed this problem recently, but couldn't do anything about it because the program start time is not available.

3. Because of #2, the info in the new tables won't be deleted when the
  recording is deleted.

4. It's minor and maybe not worth fixing, but I don't think you should
  save (and delete) new info for manual recordings.

If you stick with the current approach for #1, I see two possible
fixes for #2 and #3. First, you could save both program and recording
times in the recorded table. Second, you could munge the starttimes
in the new tables to match the recording starttime. The latter is
uglier, IMO, but has one advantage -- if program gets recorded in
multiple parts for whatever reason (backend restart, stop/reactivate,
etc.), there is a one to one correspondence between each recording
part and the new info.


I think the one to one correspondence is important, so I'll try setting the recordedprogram starttime to the recording starttime, and I'll see what I can do about #4.

_______________________________________________
mythtv-dev mailing list
[email protected]
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Reply via email to