On Fri, Apr 01, 2005 at 08:59:56PM -0500, Catherine Seppanen wrote:Attached is a (very small) patch that automatically deletes the
recording schedule for items using "Record only this showing" after the
item has recorded successfully.
kSingleRecords are deleted when mythfilldatabase runs the next day.
Why should the delete be so arbitrary? A movie that finishes at 10 AM have its schedule hang around for most of a day, but a movie that finishes at 3 AM will have its schedule deleted almost immediately. It makes no sense at all to me that the two would be related.
They are left in the database because they are needed to support reactivating a recording.
As I read it, the patch only runs when the recording completes successfully, so it's entirely in the past. How would you reactivate a recording when the show has aired and gone? This is only for kSingleRecord, "record at this specific time", and the time has passed. I don't see what benefit there is to leaving it after a successful record, especially when it gets deleted anyway after an arbitrary period of time.
kFindOnes are deleted immediately because that's how they were designed. However, now that bjm has added recordid to the oldrecorded table, they could probably be deleted in mythfilldatabase too.
Yuck. Tying a straightforward delete to a seemingly unrelated process is bad enough, don't make it worse. How is an end user supposed to form a mental model of this process? It doesn't go away when the program is done, and it doesn't stick around until the user deletes it, it just goes away randomly (from the user's point of view).
- Jeremiah
_______________________________________________ mythtv-dev mailing list [email protected] http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
