On Thu, 2005-04-14 at 00:25 -0400, Isaac Richards wrote:
> On Wednesday 13 April 2005 11:45 pm, [EMAIL PROTECTED] wrote:
> > ---------------------------------------------------------------------------
> >- Changes committed by danielk on Thu Apr 14 03:43:05 2005
> > Removes 7 lines of cruft in tv_play.cpp. --dtk
> Hmm.. Are you sure this is ok?  I think the main window resize to max (ie., 
> 1920x1080 or whatnot) has to occur before the child window is created, else 
> it can trigger a driver bug that can cut off playback at hd resolutions.

Pretty sure, I think the problem was really with resizing myWindow and
expecting mainWindow to grow. Since the player bounds are at the maximum
size possible, that shouldn't be a problem.

I'll try to contact the original reporter of the bug and get them
to test this solution today. If I don't get a response before you
do the release, I've attached a patch that adds back the mainWindow
resize.
Index: libs/libmythtv/tv_play.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/tv_play.cpp,v
retrieving revision 1.260
diff -u -r1.260 tv_play.cpp
--- libs/libmythtv/tv_play.cpp	14 Apr 2005 03:43:05 -0000	1.260
+++ libs/libmythtv/tv_play.cpp	14 Apr 2005 12:35:04 -0000
@@ -363,7 +363,12 @@
             // bit of a hack, but it's ok if the window is too
             // big in fullscreen mode
             if (fullscreen)
+            {
                 player_bounds.setSize(QSize(maxWidth, maxHeight));
+
+                // resize possibly avoids a bug on some systems
+                mainWindow->resize(player_bounds.size());
+            }
         }
 
         // player window sizing
_______________________________________________
mythtv-dev mailing list
[email protected]
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Reply via email to