On Friday 27 May 2005 15:13, Jarod Wilson wrote: > On Friday 27 May 2005 15:02, Joe Votour wrote: > > It was working fine for me, I'm pretty sure that I > > attached the correct set of patches. (Definitely, the > > "connect" was not supposed to be there - having it > > there gave me the greyed out option). > > > > Maybe it worked for me because I had the database > > entry present already, since I originally started > > mucking about with it in 0.18.1. I didn't do a > > database reset, rather I just made a backup of my > > database before migrating to CVS. Since I have the > > CVS and the 0.18.1 binaries on the machine, and switch > > between them by changing /etc/ld.so.conf, I suppose I > > could just delete the database and repopulate it from > > scratch, and restore the backup when I want to go to > > 0.18.1. > > > > I was definitely seeing the check mark retain it's > > value though, because when I switched to LiveTV, I'd > > get either SGI OpenGL, or RTC, depending on the value > > of the checkbox. I toggled it about five times just > > to make sure that I wasn't missing something. > > > > I'll redo the diffs and see what's going on... > > I've got a fully working version now. I set USING_OPENGL_VSYNC in configure > instead of using that line in mythfrontend.pro, and everything built as > expected with the #ifdefs in place. However, I think the problem is more > accurately fixed by changing the line in mythfrontend.pro from > > using_opengl: DEFINES += USING_OPENGL_VSYNC > > to > > using_opengl_vsync: DEFINES += USING_OPENGL_VSYNC > > I'm rebuilding that way to test now.
That works. Attaching the fully functional patch I'm now using. > Not sure what to say about the connect portion. Its working for me right > now w/it in there, but I started w/this patch on cvs head, not 0.18.1. This is still in there too, works without a problem... -- Jarod Wilson [EMAIL PROTECTED]
Index: libs/libmythtv/vsync.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/vsync.cpp,v
retrieving revision 1.19
diff -u -r1.19 vsync.cpp
--- libs/libmythtv/vsync.cpp 14 May 2005 19:18:36 -0000 1.19
+++ libs/libmythtv/vsync.cpp 27 May 2005 22:15:31 -0000
@@ -84,7 +84,10 @@
TESTVIDEOSYNC(nVidiaVideoSync)
TESTVIDEOSYNC(DRMVideoSync)
#ifdef USING_OPENGL_VSYNC
- TESTVIDEOSYNC(OpenGLVideoSync)
+ if ((gContext->GetNumSetting("UseOpenGLVSync", 1)) && (getenv("NO_OPENGL_VSYNC") == NULL))
+ {
+ TESTVIDEOSYNC(OpenGLVideoSync)
+ }
#endif
#ifdef __linux__
TESTVIDEOSYNC(RTCVideoSync)
Index: programs/mythfrontend/globalsettings.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/programs/mythfrontend/globalsettings.cpp,v
retrieving revision 1.253
diff -u -r1.253 globalsettings.cpp
--- programs/mythfrontend/globalsettings.cpp 26 May 2005 22:57:27 -0000 1.253
+++ programs/mythfrontend/globalsettings.cpp 27 May 2005 22:15:34 -0000
@@ -2133,6 +2133,19 @@
return gc;
}
+#ifdef USING_OPENGL_VSYNC
+static HostCheckBox *UseOpenGLVSync()
+{
+ HostCheckBox *gc = new HostCheckBox("UseOpenGLVSync");
+ gc->setLabel(QObject::tr("Enable OpenGL vertical sync for timing"));
+ gc->setValue(false);
+ gc->setHelpText(QObject::tr("If it is supported by your hardware/drivers, "
+ "MythTV will use OpenGL vertical syncing for video timing, reducing "
+ "jittering and tearing."));
+ return gc;
+}
+#endif
+
#ifdef USING_XVMC
static HostCheckBox *UseXVMC()
{
@@ -2185,6 +2198,12 @@
addTarget("0", new VerticalConfigurationGroup(true));
+#ifdef USING_OPENGL_VSYNC
+ HostCheckBox *use_opengl_vsync = UseOpenGLVSync();
+ addChild(use_opengl_vsync);
+ connect(use_mpeg, SIGNAL(valueChanged(const QString&)),
+ use_opengl_vsync, SLOT(enableOnUnset(const QString&)));
+#endif
#ifdef USING_XVMC
HostCheckBox *use_xvmc = UseXVMC();
addChild(use_xvmc);
Index: programs/mythfrontend/mythfrontend.pro
===================================================================
RCS file: /var/lib/mythcvs/mythtv/programs/mythfrontend/mythfrontend.pro,v
retrieving revision 1.59
diff -u -r1.59 mythfrontend.pro
--- programs/mythfrontend/mythfrontend.pro 13 May 2005 13:22:19 -0000 1.59
+++ programs/mythfrontend/mythfrontend.pro 27 May 2005 22:15:34 -0000
@@ -56,3 +56,4 @@
using_xvmc:DEFINES += USING_XVMC
using_xvmc_vld:DEFINES += USING_XVMC_VLD
using_xrandr:DEFINES += USING_XRANDR
+using_opengl_vsync:DEFINES += USING_OPENGL_VSYNC
pgpB8dTqFJBaP.pgp
Description: PGP signature
_______________________________________________ mythtv-dev mailing list [email protected] http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
