First off, I'm not on the dev list, so please CC me on any replies.
MythDVD seems to incorrectly identify widescreen/letter boxed DVDs. There seem to be 4 types of DVDs that can be detected, 16:9 or 4:3 and letterboxed or not for each. I don't really understand what 16:19 non-letterboxed is or what 4:3 letterboxed would be, but that's not necessarily the base of this problem.
The big problem here is that MythDVD checks the letterboxed variable on the video_attributes struct to see if the DVD is LB or not, but libdvdread no longer/never did actually set a value other than a 0 in that variable. A quick grep through the libdvdread sources shows that it is not used. The following appears to fix things on my end. It also seems that the 16:9 vs. 4:3 check should be sufficient, but if it's not then the following should definitely fix it anyway:
Index: mtd/dvdprobe.cpp
==============================
=====================================
--- mtd/dvdprobe.cpp (revision 8587)
+++ mtd/dvdprobe.cpp (working copy)
@@ -703,7 +703,7 @@
cerr << "dvdprobe.o: Could not get video format for a title" << endl;
}
- if(video_attributes->letterboxed)
+ if(video_attributes->permitted_df == 2)
{
new_title->setLBox(true);
}
I'd appreciate it if anyone who knows what 16:9 non-LB or 4:3 LB is would let me know.
Thanks,
Matt Schulkind
--- mtd/dvdprobe.cpp (revision 8587)
+++ mtd/dvdprobe.cpp (working copy)
@@ -703,7 +703,7 @@
cerr << "dvdprobe.o: Could not get video format for a title" << endl;
}
- if(video_attributes->letterboxed)
+ if(video_attributes->permitted_df == 2)
{
new_title->setLBox(true);
}
I'd appreciate it if anyone who knows what 16:9 non-LB or 4:3 LB is would let me know.
Thanks,
Matt Schulkind
_______________________________________________ mythtv-dev mailing list [email protected] http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
