> > Okay folks, here's a patch to allow users to start User Jobs from the > > Job Options menu just like you can do with transcoding and commercial > > flagging. I'm pretty confident that it works 100%, but please let me > > know if anyone runs into any problems with it.
Thanks. Looking at the code, it looks good, I'll try to get this verified and committed to CVS tomorrow sometime. If you feel like messing with it a bit more, you could make a common function called PlaybackBox::doJobQueueJob(int JobType, int JobFlags) method and then just call that from all the other 6 do* functions to minimize the code duplication. I think the only oddball is the transcoder needs the JOB_USE_CUTLIST flag passed in and the commercial flagger unsets the processing flags, but I'm not sure if it should do that. I almost wonder if the JobQueue should send RECORDING_LIST_CHANGE messages when it starts and stops jobs so that frontends can get updated lists reflecting whether a recording is being flagged, etc. but I won't throw that on you. :) If you want to make the common doJobQueueJob (or whatever it's called) method and call that from the other do* wrappers, let me know, otherwise I'll do something like that when I commit your patch. Also, please put "[PATCH]" in the subject line of any patches submitted as it helps developers find patches so they can be included. -- Chris
_______________________________________________ mythtv-users mailing list [email protected] http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users
