Chris, Thanks for the comments, will rework and should have something in a few days.
Sean --- Chris Petersen <[EMAIL PROTECTED]> wrote: > > I wrote it against my myth 0.16 install. But it > should > > work with 0.17 as well > > At least the main theme.php link won't work with .17 > -- lots of the > interface changed, along with a strong move away > from tables-based > design to heavy css. > > As for the patch, I just can't accept it as it is: > > you link to images stored in "/gif/" that don't > exist. If you want to > add new images, at least put them in a standard > location -- either in > the theme's image directory (Default's is called > img/), or if they're > global and not attached to a theme -- yours wouldn't > be -- in the global > images directory). > > You could at least change the name of the page > object to something other > than Theme_Settings. > > Please use 4-spaces instead of tabs, like the rest > of the code. I'll go > through right now to make sure that there aren't any > lingering tabs > anywhere that might confuse people. > > And like with the previous gallery patch that was > sent in last month, > you have WAY too much code in the theme file. There > should be no > reading of directory lists, or parsing of variables > in the theme file -- > all of that should be handled in the main file, > possibly by a function. > > Also, use the functions provided in utils.php like > get_sorted_files(). > > Anyway, please see my response to the previous > gallery addition: > > http://gossamer-threads.com/lists/mythtv/dev/105249 > > Nothing personal (yours does seem a little better > than the previous > submission), I've just hit a breaking point when it > comes to cleaning up > other people's code -- I still need to fix the > music/video stuff for > mythweb, and just haven't been able to find time to > do that, let alone > add new features to mythweb and nuvexport at the > pace that I would like to. > > -Chris >
_______________________________________________ mythtv-users mailing list [email protected] http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users
