Bugs item #3439688, was opened at 2011-11-17 19:31
Message generated for change (Tracker Item Submitted) made by cpudney
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=744692&aid=3439688&group_id=139835
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Data processing
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Chris Pudney (cpudney)
Assigned to: Nobody/Anonymous (nobody)
Summary: Duplicate filter creates shallow copies of peak list rows
Initial Comment:
The DuplicateFilterTask creates a new PeakList whose PeakListRows are shallow
copies of PeakListRows from the original PeakList. This means that if
PeakListRows of the original PeakList are modified they are modified in the
filtered PeakList (if they were copied) and vice versa. This is probably not
what is wanted.
Here's the code that does the (shallow) copy:
// Add all remaining rows to a new peak list
for (PeakListRow peakListRow : peakListRows) {
if (peakListRow != null)
filteredPeakList.addRow(peakListRow);
}
The addRow() call should add a "deep" copy of peakListRow.
Deep copying is probably done quite a bit so could be made a PeakListRow
utility method.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=744692&aid=3439688&group_id=139835
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Mzmine-devel mailing list
Mzmine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mzmine-devel
