Bugs item #3452300, was opened at 2011-12-06 03:40
Message generated for change (Tracker Item Submitted) made by cpudney
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=744692&aid=3452300&group_id=139835
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Chris Pudney (cpudney)
Assigned to: Nobody/Anonymous (nobody)
Summary: copyPeakListRowProperties() should deep copy PeakIdenties
Initial Comment:
PeakUtils.copyPeakListRowProperties() contains the following code:
// Copy all peak identities, if these are not already present
for (PeakIdentity identity : source.getPeakIdentities()) {
if (!containsIdentity(target, identity))
target.addPeakIdentity(identity, false);
}
This creates shallow copies of the source PeakListRow's identities in the
target PeakListRow.
This is probably not what is wanted.
For example, if you use the Duplicate Peak List Rows filter and then edit an
identity in the resulting peak list, the changes are also reflected in the
corresponding identity from the original peak list.
A possible fix would be to add a clone() method to the PeakIdentity interface
that all PeakIdentity implementations must implement:
public PeakIdentity clone();
and use this in copyPeakListRowProperties:
for (PeakIdentity identity : source.getPeakIdentities()) {
target.addPeakIdentity(identity.clone(), false);
}
Implementations might be difficult for some PeakIdentity implementations
though, e.g. AdductIdentity & ComplexIdentity, which refer to peak list rows.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=744692&aid=3452300&group_id=139835
------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of
discussion for anyone considering optimizing the pricing and packaging model
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
Mzmine-devel mailing list
Mzmine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mzmine-devel
