Hi Chris, Sandra,

I added jsr308 jar to the libraries (http://types.cs.washington.edu/jsr308/) 
and started annotating the data interfaces (net.sf.mzmine.data.*) using 
@Nonnull and @Nullable annotations. 
This has no real effect when MZmine is compiled using a standard OpenJDK 
compiler, but using the right development tools it may help to pinpoint 
problematic spots in the code where NullPointerExceptions might occur.
Also, the added benefit is that it makes it clear for the developers what was 
the intention behind the interface methods (can or cannot return null) without 
actually reading the implementation... particularly when JavaDoc comments are 
missing or out of date.

Please let me know if you have any comments/objections :)

Cheers,

Tomas


===============================================
Tomas Pluskal
G0 Cell Unit, Okinawa Institute of Science and Technology Graduate University
1919-1 Tancha, Onna-son, Okinawa 904-0495, Japan
TEL:  +81-98-966-8684

------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Mzmine-devel mailing list
Mzmine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mzmine-devel

Reply via email to