Hi Tomas, That would be great! Would you prefer changes to go in a separate branch for review? It might also make sense to add Dan (cc'd) since he's actually the working on modifications to MZmine---I've just been helping him with pushing patches back to the core MZmine team.
Adam On Sep 21, 2014, at 5:28 PM, Tomas Pluskal <plus...@oist.jp> wrote: > Dear Adam, > > Thank you for contributing! > > I will be happy to submit your patches. However, if you have more significant > changes in mind, I can add you to our SourceForge project so you can commit > your changes directly to the SVN. That way the SVN history will also remember > you as the author of the contributions. What do you think? > > Best regards, > > Tomas > > > > On Sep 21, 2014, at 1:40, Adam Tenderholt <adam.tenderh...@veritomyx.com> > wrote: > >> Hi, >> >> I work for a company called Veritomyx (www.veritomyx.com), and we have made >> some improvements to MZmine that I believe would be of interest to the >> community. I'm working on creating patches for some of the new functionality >> that will apply cleanly to MZmine trunk. Because of the nature of the >> changes, I figured it would be easiest to begin with the simplest patch >> first and then work up to the more involved patches. >> >> The attached patch simply reorganizes the imports to match the Java coding >> style specified at >> http://geosoft.no/development/javastyle.html#Package%20and%20Import%20Statements. >> This was accomplished by using the Organize Imports feature of Eclipse. >> >> Please let me know if you have any questions or concerns. >> >> Best regards, >> >> Adam >> https://sourceforge.net/u/atenderholt/profile/ >> >> >> >> >> ------------------------------------------------------------------------------ >> Slashdot TV. Video for Nerds. Stuff that Matters. >> http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk >> _______________________________________________ >> Mzmine-devel mailing list >> Mzmine-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mzmine-devel >> <organize_imports.patch> > > =============================================== > Tomas Pluskal > G0 Cell Unit, Okinawa Institute of Science and Technology Graduate University > 1919-1 Tancha, Onna-son, Okinawa 904-0495, Japan > WWW: https://groups.oist.jp/g0 > TEL: +81-98-966-8684 > Fax: +81-98-966-2890 > ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ Mzmine-devel mailing list Mzmine-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mzmine-devel
