Hi Vasily, Thanks for sending the patch! A few comments to it:
1) Your new module extends the functionality of the "Exact mass detector", but the code is mostly copy&pasted from it. We don't want to have duplicated code, so it would be better if your module calls the Exact mass detector and then filters its results. 2) Actually, I don't see the point of having two different modules that use the same algorithm. If we add your module, the Exact mass detector becomes redundant. I think it is better if you simply add the new (optional) parameter to the existing Exact mass detector module, instead of creating a new module. 3) What is the reason for having two parameters (massDefect and absoluteError)? Wouldn't a single parameter be sufficient? (generally, less parameters is better) 4) I think the way to calculate fractionalPart is a bit awkward. Wouldn't it make more sense to use Math.round() instead of the % operator? Also, please add some comments to the variables (what is the meaning of fractionalPart). Best regards, Tomas > On Mar 24, 2015, at 10:01, Vasily Avilov <avilov.vas...@gmail.com> wrote: > > Hi Tomas, > > I attached patch for current revision. If there will me any modifications > needed I will ready to make them. > > Regards, > Vasily > > пн, 23 марта 2015 г. в 16:25, Tomas Pluskal <plus...@oist.jp>: > Hi Vasily, > > Of course, we will be happy to include your new module! Please send a patch > file so we can review it. > > Cheers, > > Tomas > > > > On Mar 23, 2015, at 09:31, Vasily Avilov <avilov.vas...@gmail.com> wrote: > > > > Hello > > > > I done some modifications in sources - added one filter. May you consider > > of the source merging? > > > > Regrads, > > Vasily > > ------------------------------------------------------------------------------ > > Dive into the World of Parallel Programming The Go Parallel Website, > > sponsored > > by Intel and developed in partnership with Slashdot Media, is your hub for > > all > > things parallel software development, from weekly thought leadership blogs > > to > > news, videos, case studies, tutorials and more. Take a look and join the > > conversation now. > > http://goparallel.sourceforge.net/_______________________________________________ > > Mzmine-devel mailing list > > Mzmine-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mzmine-devel > > =============================================== > Tomas Pluskal > G0 Cell Unit, Okinawa Institute of Science and Technology Graduate University > 1919-1 Tancha, Onna-son, Okinawa 904-0495, Japan > WWW: https://groups.oist.jp/g0 > TEL: +81-98-966-8684 > Fax: +81-98-966-2890 > > <mzmine.diff.gz>------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for all > things parallel software development, from weekly thought leadership blogs to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. > http://goparallel.sourceforge.net/_______________________________________________ > Mzmine-devel mailing list > Mzmine-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mzmine-devel =============================================== Tomas Pluskal G0 Cell Unit, Okinawa Institute of Science and Technology Graduate University 1919-1 Tancha, Onna-son, Okinawa 904-0495, Japan WWW: https://groups.oist.jp/g0 TEL: +81-98-966-8684 Fax: +81-98-966-2890 ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Mzmine-devel mailing list Mzmine-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mzmine-devel
