Would it be okay that we start using the issues function of GitHub to keep track of the issues and enhancements for MZmine? That way, I can add the GridMass bug to the issue list and continue working on other changes. Someone else, or myself, can then return to this bug later on and fix it. Otherwise we might forget to fix this issue.
/Thomas -----Original Message----- From: Tomas Pluskal [mailto:plus...@oist.jp] Sent: 17. april 2015 04:13 To: Developer discussion Subject: Re: [Mzmine-devel] Quality control of MS peaks > I can use peak.getScanNumbers().length to get the amount of data points over > the chromatographic peak when I use the targeted peak detection. However, if > I use the chromatogram builder or GridMass peak detection to generate a peak > list then all peaks are listed to have 2531 data point (= the amount of MS > scans in the raw data file). Only when I do a chromatogram deconvolution, the > number is listed as the correct value. > > Should we leave this as it is or is it a mistake in the chromatogram builder > and GridMass peak detection modules? I think the GridMass should return the true number of data points (should be fixed). In case of the chromatogram builder, it is not a big problem, because everyone should run the deconvolution module afterwards. Of course, when we move these algorithms to MSDK, all of them should report the correct values and this should also be checked by junit tests. Best, Tomas =============================================== Tomas Pluskal G0 Cell Unit, Okinawa Institute of Science and Technology Graduate University 1919-1 Tancha, Onna-son, Okinawa 904-0495, Japan WWW: https://groups.oist.jp/g0 TEL: +81-98-966-8684 Fax: +81-98-966-2890 ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ Mzmine-devel mailing list Mzmine-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mzmine-devel ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ Mzmine-devel mailing list Mzmine-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mzmine-devel
