Review: Approve

> looks good, but I think it'd be cleaner to have two separate commits, as the
> issues fixed are conceptually separate

While I agree in concept, two lines of change splitting into two one line 
changes seems a bit much IMO.
-- 
https://code.launchpad.net/~alephnull-b/thruk-master-charm/+git/thruk-master-charm/+merge/362027
Your team Nagios Charm developers is subscribed to branch 
thruk-master-charm:master.

-- 
Mailing list: https://launchpad.net/~nagios-charmers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~nagios-charmers
More help   : https://help.launchpad.net/ListHelp

Reply via email to