> * classes.py lgtm > * Since flake8 max-lines=120, we should try to honor it on all files (maybe > excessive nesting from the time I used max-lines=80) I... kind of like the 80 columns limit since I work a lot with side by side files, so I'd be keen on interpreting max-lines=120 as literally a max without a min :)
> * tox.ini complexity needs to be reduced from 20 to 10 I've checked and only two functions would fail the complexity check, neither of which is affected by this changeset. I would then tend to think it'd be better to handle the complexity change in a separate MP > * unit tests should be rewritten (probably on a different MP) using pytest, > since we have functional tests that also use pytest. Aim is to avoid having 2 > different testing frameworks (unittest and pytest) within the same project. Agreed. I initially only adapted the unittests because I was not planning to have functional tests at all. Given that they do pass, perhaps we could handle their rewrite separately -- https://code.launchpad.net/~aieri/hw-health-charm/+git/hw-health-charm/+merge/364694 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to : [email protected] Unsubscribe : https://launchpad.net/~nagios-charmers More help : https://help.launchpad.net/ListHelp
