Review: Approve Looks good, but in this case I think it is better to use a > yaml string instead of |, as the latter is for pre-formatted text that needs to preserve newlines.
Diff comments: > diff --git a/src/config.yaml b/src/config.yaml > index 37dda77..a6e8797 100644 > --- a/src/config.yaml > +++ b/src/config.yaml > @@ -20,3 +20,10 @@ options: > type: boolean > default: True > description: Enable the use of freeipmi tools to monitor hardware status. > + ipmi_check_options: > + type: string > + default: '' > + description: | > + Additional options to be passed to check_ipmi_sensor. For non-standard > + ipmi implementations you might for example need > + "--seloptions '--assume-system-event-records'" You want "description: >" instead of "description: |" to declare the multi-line string, as it will render better without the hard coded newlines. -- https://code.launchpad.net/~aieri/hw-health-charm/+git/hw-health-charm/+merge/364756 Your team Nagios Charm developers is subscribed to branch hw-health-charm:oo-rewrite-integration. -- Mailing list: https://launchpad.net/~nagios-charmers Post to : [email protected] Unsubscribe : https://launchpad.net/~nagios-charmers More help : https://help.launchpad.net/ListHelp
