I consider this MP ready for review. * Functional tests: 14 passed, 2 warnings in 831.51 seconds (warnings due to charmhelpers lib) * Unit and lint tests remain the same (passed).
The only consideration is about the need to have not only tools.zip on the main folder of the repo, but also tools-checksum.zip and tools-missing.zip (Makefile's resource_check target verifies that they exist). * tools.zip contains megacli, sas2ircu and sas3ircu, since "manufacturer=test" installs all 3 tools (so they're expected within the zip file) * tools-checksum.zip is the same as above, but megacli can be replaced by any content (ie. empty file), so checksum verification will fail * tools-missing.zip is the same as above, but megacli is removed (ok, then, not the same :) so this tool install will fail (and block the unit) -- https://code.launchpad.net/~aluria/hw-health-charm/+git/hw-health-charm/+merge/369278 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to : [email protected] Unsubscribe : https://launchpad.net/~nagios-charmers More help : https://help.launchpad.net/ListHelp
