Review: Needs Fixing
Please find comment inline. Other than that, +1 to merge it.
Thank you.
Diff comments:
> diff --git a/scripts/postfix_loopback_only.sh
> b/scripts/postfix_loopback_only.sh
> index 77c388c..ae5066b 100755
> --- a/scripts/postfix_loopback_only.sh
> +++ b/scripts/postfix_loopback_only.sh
> @@ -1,7 +1,11 @@
> #!/bin/sh
>
> POSTFIX_CONF="/etc/postfix/main.cf"
> +CODENAME="$(lsb_release -a | grep -E '^Codename:' | awk '{print $2}')"
This could be: $(lsb_release -cs)
> +if [ $CODENAME = "trusty" ] ; then CMD="/etc/init.d/postfix restart" ; else
> CMD="systemctl restart postfix" ; fi
> +
> if grep -qE '^inet_interfaces.*all' $POSTFIX_CONF; then
> sed -i 's/^inet_interfaces.*/inet_interfaces = loopback-only/'
> $POSTFIX_CONF
> - systemctl restart postfix
> + $CMD
> fi
> +
--
https://code.launchpad.net/~peppepetra86/charm-nagios/+git/charm-nagios/+merge/387651
Your team Nagios Charm developers is subscribed to branch charm-nagios:master.
--
Mailing list: https://launchpad.net/~nagios-charmers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~nagios-charmers
More help : https://help.launchpad.net/ListHelp
