Module: nagvis
Branch: master
Commit: e26ce5e47f8da042b7c6a075edbec0c8878ff6a6
URL:    
http://nagvis.git.sourceforge.net/git/gitweb.cgi?p=nagvis/nagvis;a=commit;h=e26ce5e47f8da042b7c6a075edbec0c8878ff6a6

Author: Lars Michelsen <[email protected]>
Date:   Sun Oct 31 20:17:43 2010 +0100

Additional small js performance improvements

---

 share/frontend/nagvis-js/js/frontendEventlog.js |   75 +++++++++++------------
 1 files changed, 37 insertions(+), 38 deletions(-)

diff --git a/share/frontend/nagvis-js/js/frontendEventlog.js 
b/share/frontend/nagvis-js/js/frontendEventlog.js
index 3c3be30..ecd2c4e 100644
--- a/share/frontend/nagvis-js/js/frontendEventlog.js
+++ b/share/frontend/nagvis-js/js/frontendEventlog.js
@@ -25,6 +25,8 @@
  * @author     Lars Michelsen <[email protected]>
  */
 
+var _eventlog = null;
+
 var oSeverity = {
        'debug':    4,
        'info':     3,
@@ -57,40 +59,38 @@ function eventlogToggle() {
  * @author     Lars Michelsen <[email protected]>
  */
 function eventlogInitialize() {
-       var oEventlog = document.getElementById('eventlog');
+       var doc = document;
+       var oEventlog = doc.createElement('div');
+       oEventlog.setAttribute("id","eventlog");
+       oEventlog.style.overflow = 'auto';
        
-       if(!oEventlog) {
-               oEventlog = document.createElement('div');
-               oEventlog.setAttribute("id","eventlog");
-               oEventlog.style.overflow = 'auto';
-               
-               var oEventlogControl = document.createElement('div');
-               oEventlogControl.setAttribute("id","eventlogControl");
-               oEventlogControl.appendChild(document.createTextNode('_'));
-               oEventlogControl.onmouseover = function() {
-                       document.body.style.cursor='pointer';
-               };
-               
-               oEventlogControl.onmouseout = function() {
-                       document.body.style.cursor='auto';
-               };
-               
-               oEventlogControl.onclick = function() {
-                       eventlogToggle();
-               };
-               
-               document.body.appendChild(oEventlog);
-               
-               document.body.appendChild(oEventlogControl);
-               oEventlogControl = null;
-               
-               // Hide eventlog when configured
-               if(oPageProperties.event_log_hidden == 1) {
-                       eventlogToggle();
-               }
-       }
+       var oEventlogControl = doc.createElement('div');
+       oEventlogControl.setAttribute("id","eventlogControl");
+       oEventlogControl.appendChild(doc.createTextNode('_'));
+       oEventlogControl.onmouseover = function() {
+               doc.body.style.cursor='pointer';
+       };
+       
+       oEventlogControl.onmouseout = function() {
+               doc.body.style.cursor='auto';
+       };
+       
+       oEventlogControl.onclick = function() {
+               eventlogToggle();
+       };
+       
+       doc.body.appendChild(oEventlog);
+       
+       doc.body.appendChild(oEventlogControl);
+       oEventlogControl = null;
+       
+       // Hide eventlog when configured
+       if(oPageProperties.event_log_hidden == 1)
+               eventlogToggle();
        
+       _eventlog = oEventlog;
        oEventlog = null;
+       doc = null;
 }
 
 /**
@@ -107,13 +107,13 @@ function eventlogInitialize() {
  */
 function eventlog(sComponent, sSeverity, sText) {
        if(typeof(oPageProperties) != 'undefined' && oPageProperties !== null 
&& oPageProperties.event_log && oPageProperties.event_log != '0') {
-               var oEventlog = document.getElementById('eventlog');
+               var doc = document;
                
-               if(!oEventlog) {
+               if(_eventlog === null) {
                        eventlogInitialize();
                        eventlog("eventlog", "info", "Eventlog initialized 
(Level: "+oPageProperties.event_log_level+")");
-                       oEventlog = document.getElementById('eventlog');
                }
+               var oEventlog = _eventlog;
 
                if(typeof oSeverity[sSeverity] === 'undefined') {
                        eventlog('eventlog', 'error', 'Unknown severity used, 
skipping: '+sSeverity+' '+sComponent+': '+sText)
@@ -132,21 +132,20 @@ function eventlog(sComponent, sSeverity, sText) {
                        }
                        
                        // Format the new log entry
-                       var oEntry = document.createTextNode(getCurrentTime()+" 
"+sSeverity+" "+sComponent+": "+sText);
+                       var oEntry = doc.createTextNode(getCurrentTime()+" 
"+sSeverity+" "+sComponent+": "+sText);
                        
                        // Append new message to log
                        oEventlog.appendChild(oEntry);
                        oEntry = null;
                        
                        // Add line break after the line
-                       var oBr = document.createElement('br');
-                       oEventlog.appendChild(oBr);
-                       oBr = null;
+                       oEventlog.appendChild(doc.createElement('br'));
                        
                        // Scroll down
                        oEventlog.scrollTop = oEventlog.scrollHeight;
                }
                
                oEventlog = null;
+               doc = null;
        }
 }


------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Nagvis-checkins mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nagvis-checkins

Reply via email to