Thanks Kave - I have added your fix to the git repository!
Regards,
Greg
----- Original Message -----
From: kavedai
To: g...@censoft.com
Cc: jor...@cosmicpenguin.net ; nanogui-subscr...@linuxhacker.org
Sent: Thursday, April 08, 2010 12:12 AM
Subject: Find a bug in Microwindows-0.92
Dear Greg Haerr:
I'm an engineer from China. I have ported Microwindows GUI to
linux-2.6.28. I utilize "tslib" to filter the kernel input events which come
from touch screen, and pass events to Microwindows GUI. I found an issue about
Microwiondows:
In microwin/src/drivers/mou_tslib.c, line 81, the code "if (ret < 0)" causes
pass invalid touch screen events to Microwinodws GUI. When there is no new
event occurs, ret==0, but PD_Read() will get invalid event from local variable
"struct ts_sample samp". In arm-linux-gcc 3.4.4, this local variable default
value is equal to last time it evaluated. So the MW GUI can work correctly (But
first time touch can not respond correctly). In arm-linux-gcc 4.4.0, this local
variable default value is invalid, the Microwindows can not work well. When I
modify "if (ret < 0)" to "if (ret <= 0)", it is ok.
I hope this message may provide help for Nano-X project.
B.R.
Kave Dai
