On Thu, Jun 03, 2010 at 08:13:32PM +0200, Daniel Nyström wrote:
> 2010/6/3 Aaron J. Grier <agr...@poofygoof.com>:
> > On Thu, Jun 03, 2010 at 03:00:57PM +0200, Daniel Nyström wrote:
> >> >    assert (c < psd->ncolors);
> >
> > the assertion is incorrect for non-palettized video modes.  I would just
> > remove the asserts, or change it to
> >
> >        assert(psd->pixtype != MWPF_PALETTE || c < psd->ncolors)
> 
> Since fblin24.c is specifically for 24bit RGB I guess pixtype will
> never be anything but MWPF_TRUECOLOR888, so just removing the assert
> would do?

that's what I figured and why I simply removed the assert.  as to what
should be commit back to the trunk, I defer to Greg's judgement.

-- 
  Aaron J. Grier | "Not your ordinary poofy goof." | agr...@poofygoof.com

---------------------------------------------------------------------
To unsubscribe, e-mail: nanogui-unsubscr...@linuxhacker.org
For additional commands, e-mail: nanogui-h...@linuxhacker.org

Reply via email to