I’ve been talking with Gerry and Ian about making the following changes to the Project class. Right now a Project can be re-initialized, given a new build file, but it will not work correctly. I have proposed that we remove the current ctor (no-params) and add the following:

 

Project(string filename)

Proejct(XmlDocument doc)

 

Also, I would remove the set_BuildFileName (and any other places where re-init can happen) and clean up Project initialization in NAnt, and from the tests.

 

By making these changes we will re-enforce the fact that the project class should be single use; that there is a mapping between a class instance and a build file. It will also make it a little easier to hand off newly created build files (XMLDocument) from within an IDE or shell :)

 

Suggestions/Comments?

Reply via email to