Robert,
I've checked this in. thanks a lot. As for the exception - I think that the approach that you've taken is correct. I don't view the "File already added " error as catastrophic. As long as the user is informed it should be OK. I think a property for this might be overkill. We already have the inherited FailOnError property which defaults to true. So if you wanted to change to use this thats an option. Personally I can't think of a where I'd want to cancel my source control add operations if a few files were already there. Others may have different opinions. >I have created a task that will add files to SourceSafe. Here is an >example of its usage. > ><vssadd dbpath="c:\sourcesafe\srcsafe.ini" user="" password="" path >="$/DLLAdd" comment="Hello World"> > <fileset basedir="U:\AddFolder"> > <includes name="*.dll"/> > </fileset> ></vssadd> > >Currently it doesn't support a recursive add. If a file is attempted to be >added to VSS that is currently in VSS an exeption is thrown. I wrote it so >the exception is caught and it moves onto the next file. I didn't know if >we wanted a property or not for continue. The logic for this catch may >need some work... it just doesn't feel right though it works. > >This is my first patch to an open source project so any feedback would be >welcome. > The only comment I'd make is to be aware of whitespace. Nant has standardized on using spaces instead of tabs. Other than that its all good. Thanks again. Ian > >Rob Jefferies > >(See attached file: AddTask.cs) > _______________________________________________________________ Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [EMAIL PROTECTED] Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
