Looks like a better way would be to check the NodeType property of XmlNode.
childNode.NodeType == XmlNodeType.Element It will also make the code much more readable :) > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:nant-developers- > [EMAIL PROTECTED]] On Behalf Of Scott Hernandez > Sent: Wednesday, September 18, 2002 3:34 PM > To: 'Shaw, Gerry' > Cc: [EMAIL PROTECTED] > Subject: RE: [nant-dev] Commenting out tasks > > Yeah, that isn't there for this reason. If you remove it you will get > some serious failures. > > I believe '#' is not a valid element name character in xml, or first > character. When you get to nodes like comments or text or other > internal, unnamed types, they all start with #. > > This line is there to make sure that the namespace is the same and node > type is not an internal type (like the text node). > > !childNode.Name.StartsWith("#") && > childNode.NamespaceURI.Equals(doc.DocumentElement.NamespaceURI) > > We can probably replace that startswith("#") check with some other > check. It is done in many places. When I converted over most of the code > from XPath selection to node interation, this was one of the problems I > encountered. In XPath, text nodes are not returned since selection is > specific to the nodes you want, by name. I meant to come back and > re-factor this after I had read up a little more. Maybe a better > solution can be found now. > > > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]] On Behalf Of Shaw, > Gerry > Sent: Wednesday, September 18, 2002 11:02 AM > To: '[EMAIL PROTECTED]' > Subject: [nant-dev] Commenting out tasks > > Poking around in the Project.InitializeProjectDocument() I've noticed > that if task names are prefixed with # they won't be executed. > I'm not sure who implemented this but it seems like an undocumented hack > to me.� Are there any objections to removing this? > > > > ------------------------------------------------------- > This SF.NET email is sponsored by: AMD - Your access to the experts > on Hammer Technology! Open Source & Linux Developers, register now > for the AMD Developer Symposium. Code: EX8664 > http://www.developwithamd.com/developerlab > _______________________________________________ > Nant-developers mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nant-developers ------------------------------------------------------- This SF.NET email is sponsored by: AMD - Your access to the experts on Hammer Technology! Open Source & Linux Developers, register now for the AMD Developer Symposium. Code: EX8664 http://www.developwithamd.com/developerlab _______________________________________________ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
