Ian
Brian,
thanks for your contribution
I just had a brief skim thru the code and it looks OK. As for style conventions just the usual.
1. open braces on the same line
2. use spaces not tabs for indenting.
Visual studio will by default get both of these wrong if thats what you're using.
one other thing. I notice you changed if(project != null) to
if(null != project)
This isn't really necessary in C# as the expression (project = null) does not evaluate to bool as it would in C++.
I'll commit this later today
Ian
This was purely motivated by me wanting to be able to use "-f:" instead of "-buildfile:". Bold! :)
options:
-help print this message
-projecthelp print project help information
-buildfile:<file> use given buildfile
-file:<file> ''
-f:<file> ''
-find search parent directories for buildfile
-D:<property>=<value> use value for given property
-verbose, -v displays more information during build process
-logger: use given class name as logger
-logfile:, -l: use value as name of log output file
I also did some thoroughly anal-retentive "refactoring". (Made a CommandLineOption enum, moved the above console output into its own function.)
Don't know that these changes warrant any additions to Nant.Console.Tests, but if the Council of Elders feels it appropriate, I'd be happy to oblige. :)
Oh, and I would appreciate being alerted to any style/convention violations I may have committed.
Brian Deacon
_________________________________________________________________
MSN 8: advanced junk mail protection and 2 months FREE*. http://join.msn.com/?page=features/junkmail
-------------------------------------------------------
This SF.NET email is sponsored by: Take your first step towards giving your online business a competitive advantage. Test-drive a Thawte SSL certificate - our easy online guide will show you how. Click here to get started: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0027en
_______________________________________________
Nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
-------------------------------------------------------
This SF.NET email is sponsored by: Take your first step towards giving your online business a competitive advantage. Test-drive a Thawte SSL certificate - our easy online guide will show you how. Click here to get started: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0027en
_______________________________________________
Nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
