cool. I've made that change to check for a currentframework. I'll commit tomorrow if there are no objections.I haven't really tested it, but it looks good ... I didn't like the extra attribute either ... I'll try to test it later today or tomorrow ... (that means tomorrow) ...
But you'll only have to execute this block if there is a current framework (I tend to forget that this is possible too) ...
Jaroslaw, what do you think ? Does this solution seem good to you ?
Ian
Gert
----- Original Message ----- From: "Ian MacLean" <[EMAIL PROTECTED]>
To: "Gert Driesen" <[EMAIL PROTECTED]>
Cc: "Jaroslaw Kowalski" <[EMAIL PROTECTED]>; "NAnt Developers"
<[EMAIL PROTECTED]>
Sent: Sunday, September 07, 2003 7:19 PM
Subject: Re: [nant-dev] [PATCH] New fileset option "fromframework"
Firstly I noticed that the patch failed when you specified patterns instead of filenames eg "*.dll".
------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
