Sascha, I guess I have this question... Should both these functionalities be combined in a single task?
Why not just support two sep. tasks. <concat ...> <.../> </> <filter .../> That leaves the choice to the user about what they want to do. They can mix and match anyway they want. ----- Original Message ----- From: "Sascha Andres" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Wednesday, September 17, 2003 1:15 PM Subject: Re: [nant-dev] New task: cat > Hi, > * Sascha Andres wrote on 17.09.2003 (21:56): > > Perhaps it's time to move it to NAnt.Core? I'll have a look, > > and see what needs to be done to implement the filter I > > mentioned earlier. After that, I'll post a patch for that > > one. > > I had a look at the concat task. The concat task uses a > FileStrem to read and write. So it can handle binary files > as well as text files. It has one caveat to transfer this > way: It makes it hard to work with a filter using regular > expressions. > > I see the following possibilities: > > * Add a filter attribute. If set use a StreamReader / > StreamWriter combination. I don't really like this one, as > this sounds like bad design. > * Drop the filter idea. I think a filtering task would be > nice to have.- At least when it's done with the power of > regular expressions. > * Use concat as a binary save cat, rename my cat task to > something more regex specific, but leave the cat > functionality. Add fileet support, make filter not > optional. > > What do you think? ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers