Hi Gert and thanks for comments,
> Some small remarks :
>
> 1. I'm not sure there should be a Verbosity property on Element, why do
you
> think there should be one ?
Main reason - easy to implement and accessible everywhere (all tasks, all
types). If it is problem, we could move it into Task instead.
I think it could be handy sometimes to define type and add Verbosity=Debug
to it to enable some messages...
> 2. Why did you rename the Verbose property of Project to X__Verbose ?
Just to make sure everywhere is called Task.Verbose/Element.Verbosity
instead of Project.Verbose. Sorry - this should be renamed back.
> 3. I think we should come up with a better name instead of Verbosity, no ?
Sure. Suggest name :-) I'd considered use of Verbose property for that, but
it brokes compatibility
> Other than that it looks ok (but I'd hold off on committing it until Scott
> and/or Ian have responded) ...
Looking forward to them!
> Gert
>
> ----- Original Message -----
> From: "Martin Aliger" <[EMAIL PROTECTED]>
> To: "! nant" <[EMAIL PROTECTED]>
> Sent: Monday, January 19, 2004 3:37 PM
> Subject: Re: [nant-dev] verbosity
>
>
> > Gert, Ian, Scott - how you like this patch? Do you think it is
> submittable?
> >
> > I also found some minor bugs from mine previous mail. Here it is patched
> > (patch against anon-cvs from 15/01)
> >
> > Martin
> >
> > ----- Original Message -----
> > From: "Martin Aliger" <[EMAIL PROTECTED]>
> > To: "! nant" <[EMAIL PROTECTED]>
> > Sent: Wednesday, January 14, 2004 4:03 PM
> > Subject: [nant-dev] verbosity
> >
> >
> > > Hi all,
> > >
> > > I found some time to look into verbosity in NAnt. I think verbose=true
/
> > > false is not sufficient control in task level. In project level you
> > > have -debug, -quiet and normal run.
> > >
> > > What I do in this patch, is add new attribute at element level (so
> enable
> > > use it for all tasks and types) names "verbosity". So code like this
is
> > now
> > > possible:
> > > <xmlpeek refid="x1" xpath="book/author/name" property="authorname"
> > > verbosity="Error"/>
> > > or
> > > <exec program="foo.exe" commandline="1 2 3" failonerror="false"
> > > vebosity="Debug"/>
> > >
> > > First one suppress any message except errors, second one does
opposite -
> > > turns on all messages. When no verbosity is specified, default is
taken
> > from
> > > project setting - so you override -debug or -quiet option for this
> > specific
> > > task.
> > >
> > > Next use we could have from this is better control over logging when
use
> > > task embedded in another task/function. E.g. <csc> or <resgen> from
> > > <solution> or <xmlpeek> task from xml::peek function:
> > > [Function("peek")]
> > > public string XmlPeek(string refid,string xpath) {
> > > XmlPeekTask peek = new XmlPeekTask();
> > > peek.Verbosity = Level.Warning;
> > > ...
> > > }
> > >
> > >
> > > I hope you will like it. All old behaviours (log4net loggers, verbose
> > > attribute) should work as they did before. I was also careful to do
not
> > miss
> > > to comment, properly format code etc.
> > >
> > > One note: It is important to use Element.Log() not Project.Log() in
all
> > > tasks.
> > >
> > > Regards,
> > > Martin
> > >
> > > btw: I dont like much how thresholds are done. Also two loggers
(log.cs
> /
> > > log4net) seems to be redundant. What about to use log4net even for
> common
> > > user log messages? Why to use it only for internals. log4net could be
> used
> > > very nicely even for user output - log to file+screen, message
> formatting,
> > > cyclic logs etc etc etc...
> > >
> >
>
>
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
