Thanks -- we're hoping to start converting to NUnit2 soon.
I found another problem with the NUnit1 task. The haltonerror and haltonfailure attributes are being used incorrectly by the task. It is my understanding that those properties should throw a build exception when they are true if any error/failure occurs. In the case of a failure/error, the current NUnit1 task will throw a build exception after the entire task is finished regardless of the state of these two properties.
I fixed this by removing all references to the _failuresPresent and _errorsPresent variables. They are redundant with the exception that is being thrown in ExecuteTest method(specifically the code in the ExecuteTask method). This change will make the NUnit1 task function like it did in previous version of NAnt and work like the NUnit2 task does.
If you could also review/commit these changes I would appreciate it.
Thanks -andy
X-OriginalArrivalTime: 19 Mar 2004 16:44:39.0636 (UTC) FILETIME=[78A10140:01C40DD1]
Any,
I committed your fix to cvs, however I would advise you to upgrade to NUnit 2.x asap.
Gert
----- Original Message ----- From: "Andy Sipe" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Friday, March 19, 2004 4:46 PM Subject: [nant-dev] problem with NUnit1 Task
> We're in the process of upgrading to 0.84 from 0.81. I found what appears
> to be a problem with the NUnit1 task. It no longer creates the test
output
> files. I tried several variants of the task and couldn't get it to
function
> correctly, so I took a look at the code.
>
> It seems that the formatters are never being initialized in the NUnit1Task
> class. I updated the ExecuteTest method to read as follows:
>
> ...
> NUnitTestData testData = test.GetTestData();
> //this was already there
> foreach (FormatterElement element in FormatterElements)
> //**new
> testData.Formatters.Add(element.Data);
> //**new
> ...
>
> Could someone put this into the source tree?
>
> Thanks -andy
>
> _________________________________________________________________
> Get rid of annoying pop-up ads with the new MSN Toolbar - FREE!
> http://clk.atdmt.com/AVE/go/onm00200414ave/direct/01/
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
> _______________________________________________
> nant-developers mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/nant-developers
>
>
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
_________________________________________________________________
Get reliable access on MSN 9 Dial-up. 3 months for the price of 1! (Limited-time offer) http://click.atdmt.com/AVE/go/onm00200361ave/direct/01/
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
