Troy,
I think I'd still prefer to have support for multiple top-level filesets, instead of nested fileset. The nested fileset does not have a relation with its parent fileset, as it would only be used when you need a separate base directory. You'd also need to be able to get a separate set of matching files for each fileset (as you need to know what files correspond with what basedir), so I don't think it makes much sense to have nested filesets.
Also, having multiple top-level filesets would better match the Ant implementation.
Gert
----- Original Message ----- From: "Troy Laurin" <[EMAIL PROTECTED]>
To: "Nant-Developers (E-Mail)" <[EMAIL PROTECTED]>
Sent: Sunday, August 29, 2004 12:16 PM
Subject: Re: [nant-dev] Re: Add support for multiple filesets to the <zip> task.
Troy Laurin wrote:Gert Driesen wrote:
Not only is this not as clean as having support for multiple filesets, it also causes problems for tasks that use the relative path to the base directory (like the <zip> task does to determine the directory within the zip file).
Ant supports this in various (all tasks that use filesets ?) tasks.
Rather than modify every task that uses a fileset, is it worth (is it correct?) modifying fileset to be self-nesting?
For example, your references element from above might become:
<references> <includeset basedir="C:/Test" /> <include name="AssemblyA.dll" /> <include name="bin/AssemblyB.dll" /> <include name="whatever/AssemblyC.dll" /> </includeset> <includeset basedir="D:/Test/whatever" /> <include name="AssemblyD.dll" /> <include name="AssemblyE.dll" /> </includeset> </references>
or equivalently (slightly more concise):
<references basedir="C:/Test" /> <include name="AssemblyA.dll" /> <include name="bin/AssemblyB.dll" /> <include name="whatever/AssemblyC.dll" /> <includeset basedir="D:/Test/whatever" /> <include name="AssemblyD.dll" /> <include name="AssemblyE.dll" /> </includeset> </references>
You could then play with includesets as required to ensure each included file has the correct relative path.
If this isn't a bad idea, I could probably knock together a prototype next weekend...
Thoughts?
-- Troy
Ping?
------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
