If this change is done, what about to lower verbosity when deleting non-existing files/folders also? I think verbose level is ok for that (todays it is error via BuildException).
Martin Aliger > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On > Behalf Of Owen Rogers > Sent: Tuesday, November 23, 2004 4:28 PM > To: Matthew Mastracci > Cc: Gert Driesen; [EMAIL PROTECTED] > Subject: Re: [nant-dev] Re: Fileset / <delete> task change > > +1 on this. i can't tell you the number of times i have accidentally > deleted folders because i forgot that the delete task doesn't > respect excluded folders. > > > On Tue, 23 Nov 2004 08:13:28 -0700, Matthew Mastracci > <[EMAIL PROTECTED]> wrote: > > Sounds good to me. I think the behaviour is more > reasonable overall. > > If I specify that a file should be excluded, its directory > should not > > be removed, no matter what. > > > > I always found the delete task to be a bit odd. ;) > > > > Matt. > > > > > > > > Gert Driesen wrote: > > > > >Hi Matthew, > > > > > >I've had another look at how our <delete> task is working > right now, > > >and the more I think of it, the more I'm convinced that we should > > >change it to match the Ant <delete> task. > > > > > >Right now, we remove all directories that are matched by > the fileset. > > >But this does not respect any excludes. > > > > > >When you have the following directory structure : > > > > > ><project base directory>\ > > > test\ > > > web.config > > > subdir\ > > > web.config > > > > > >And you'd execute the following task : > > > > > ><delete> > > > <fileset basedir="."> > > > <include name="test/**/*" /> > > > <exclude name="test/**/web.config" /> > > > </fileset> > > ></delete> > > > > > >Then the <project base directory>\test\subdir would be completely > > >removed (although, there's a web.config file in there that > should not > > >be deleted), as that directory is returned in the DirectoryNames > > >collection of the fileset, and alls path returned in that > collection > > >are completely removed by the <delete> task. > > > > > >Instead, it might be better to first remove all matching > files, and > > >then remove all matching directories that are empty (and > do this only > > >if "includeemptydirs" is set to true). > > > > > >What do you think ? > > > > > >Gert > > > > > > > > > > > > > > > > > > > > > -- > CruiseControl.NET - http://ccnet.thoughtworks.com > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from > real users. > Discover which products truly live up to the hype. Start reading now. > http://productguide.itmanagersjournal.com/ > _______________________________________________ > nant-developers mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nant-developers > > ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
