Hi Ryan,
these changes are good rom my point of view.
I have ony one minor thing what I can't test since I have difficulties
to debug nant at the moment.
MSBuildProject.cs within DetermineProductVersion line 279
if (_productVerNode != null) {
Version _ver = new Version(_productVerNode.InnerText);
_productVerNode.InnerText might be empty especially in vb.net projects.
Which results in an exception since "" is not valid vor Version
constuctor. You might use following:
if (_productVerNode != null &&
!StringUtils.IsNullOrEmpty(_productVerNode.InnerText))
Well done
Dominik
Am 06.08.2011 21:12, schrieb Ryan Boggs:
> Hi,
>
> I'm thinking that at this point, since I believe I fixed the one or two
> things from the comments I received some months ago, I will commit these
> changes by end of day Monday unless I hear any objections before then.
> From there, I will perform some nightlys with these changes for public
> testing. Sound good?
>
> Thanks,
> Ryan
>
>
--
The answer to the great question of life,
the universe and everything is 42 (Douglas Adams)
------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts.
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
nant-developers mailing list
nant-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nant-developers
