Title: Source Code change suggestion

I have made the following modification to ExternalProgramBase.cs

Between the p.Start() and return p; at line 393-4 :

try
                {
                        while (true)
                        {
                                // read line
                                string line = p.StandardOutput.ReadLine();
                                if (line == null)
                                {
                                        break;
                                }
                                // display line
                                Log(Level.Verbose, line);
                        }
                        while (true)
                        {
                                // read line
                                string line = p.StandardError.ReadLine();
                                if (line == null)
                                {
                                        break;
                                }
                                // display line
                                Log(Level.Verbose, line);
                        }

                }
                finally
                {
                        string msg1 = string.Format(
                                CultureInfo.InvariantCulture,
                                LogPrefix + "Finished '{1} ({2})' in '{0}'",
                                p.StartInfo.WorkingDirectory,
                                p.StartInfo.FileName,
                                p.StartInfo.Arguments);

                        Log(Level.Verbose, msg1);
                }

I made this change to stop output from exec calls coming out in the main NANT build window, unless I set the loglevel to Verbose

I submit this as a useful modification to go back in the release, but it is a personal view :-)
I suspect that others may want to make the Log calls at Info level :-)

My situation is that I am lining NANT up to build >250 components, so I want the build output to be as small as possible.

I have changed various other Log calls through the application to Verbose as well, but as I say, that's a personal opinion.

I can submit a list of the changes if required - there are about 20 calls. It does make the output look very neat :

            [solution] Building 'IlFixMerge' [debug]...

           BUILD SUCCEEDED

           Total time: 4.6 seconds.

The above includes 6 separate targets and running several perl scripts for .csproj manipulation.

Simon Rowe


________________________________________________________________________
This e-mail has been scanned for all viruses by Star Internet. The
service is powered by MessageLabs. For more information on a proactive
anti-virus service working around the clock, around the globe, visit:
http://www.star.net.uk
________________________________________________________________________

Reply via email to