Just trying out the <asminfo> task:
http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/nantcontrib/NAntContrib/src/Tasks/AssemblyInfoTask.cs?rev=1.2&content-type=text/vnd.viewcvs-markup
Is there a reason it always generates a log4net declaration? I don't use log4net so I get a compile error whenever I try to use it. Would it not be more sensible to only set a log4net line if an appropriate attribute is set? Maybe it should be set 'true' by default for backwards compatibility but if that's not a concern I'd default it to false since I think a lot of people aren't using log4net.
E.g. instead of
att = new CodeAttributeDeclaration("log4net.Config.Domain");
att.Arguments.Add(new CodeAttributeArgument("UseDefaultDomain",new
CodePrimitiveExpression(true)));
ccu.AssemblyCustomAttributes.Add(att);have
if ( UseLog4netDomain )
{
att = new CodeAttributeDeclaration("log4net.Config.Domain");
att.Arguments.Add(new CodeAttributeArgument("UseDefaultDomain",new
CodePrimitiveExpression(true)));
ccu.AssemblyCustomAttributes.Add(att);
}where 'UseLog4netDomain' is a new property on the task.
Mike
------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 _______________________________________________ NAntContrib-Developer mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer
