Re: [NAntC-Dev] VB6 Task

Ian MacLean Wed, 24 Mar 2004 17:42:41 -0800

I think you're right Terry. Looking at the other code there its obvious it should be checking the project file date. I've comitted your change. Thanks for the find.

Ian
Terry Austin wrote:

It's still not quite working.  I changed the build script to "touch" each
VBP file before calling the vb6 task so the modified date would be newer and
force a rebuild, but it's still not building the VB project.  I've been
looking at the vb6 task source code and I wonder what this line does in the
ProjectNeedsCompiling method:
string fileName =
FileSet.FindMoreRecentLastWriteTime(outputFileInfo.FullName,
outputFileInfo.LastWriteTime);
It looks like it compares the last write date of the output binary file to
itself.  Not quite sure why you would need to do that.  What am I missing
here?  Could it be that this is supposed to reference the project file
instead?  It would not be compared anywhere else in the method; the
ParseProjectFile method would not add it to any of the FileSet objects
returned, right?
Everything seems to build correctly if I change the above line to:
string fileName = FileSet.FindMoreRecentLastWriteTime(projectFile,
outputFileInfo.LastWriteTime);
Any thoughts?
Terry Austin
Progressive Partnering
[EMAIL PROTECTED]
-----Original Message----- From: Ian MacLean [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 24, 2004 4:29 AM To: Gert Driesen Cc: Terry Austin; [EMAIL PROTECTED] Subject: Re: [NAntC-Dev] VB6 Task
One step ahead of you Gert :) I just made a small fix to correct this issue.
The task was resolving relative paths from the build file dir rather than
from the dir containing the vbp file.
Please give it a try Terry and let us know if it works fine on your system.
I agree with Gert that an "alwaysCompile" attribute should not be needed.
You can always use the touch task before using <vb6> to get the same
behaviour.
Ian

Gert Driesen wrote:
Hi Terry,

I would actually prefer to fix the original issue. I'll look into installing VB6 on one of my system to track the issue down and test a fix.

Gert
----- Original Message -----
From: "Terry Austin" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Monday, March 22, 2004 6:11 PM
Subject: [NAntC-Dev] VB6 Task
All,

I was working with the vb6 task in a build file and found that the logic that determines if the project should be compiled seems broken unless the project file exists in the same directory as the build file. I don't

really

have time to debug that issue right now, but as a quick fix I added a new "alwayscompile" task attribute that, when true, insures that the project gets compiled, regardless of the outcome of the NeedsCompiling()
method.
I

like this solution because I generally always want to rebuild all projects during the build, and it's nice to be able to force a rebuild when you

want.
The modified task is attached. If any maintainers wish to add this modification to the source tree, feel free.
Terry Austin
Progressive Partnering
[EMAIL PROTECTED]
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ NAntContrib-Developer mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer
--
Ian MacLean, Developer,
ActiveState, a division of Sophos
http://www.ActiveState.com
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ NAntContrib-Developer mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer

-- Ian MacLean, Developer, ActiveState, a division of Sophos http://www.ActiveState.com

-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
NAntContrib-Developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer

Re: [NAntC-Dev] VB6 Task

Reply via email to