Patches item #1081451, was opened at 2004-12-08 10:37 Message generated for change (Comment added) made by jvilalta You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=474853&aid=1081451&group_id=54790
Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Jay Vilalta (jvilalta) Assigned to: Gert Driesen (drieseng) Summary: vsshistory task Initial Comment: This task is similar to the ant vsshistory task in that it allows you to do diffs between certain versions and/or dates. ---------------------------------------------------------------------- >Comment By: Jay Vilalta (jvilalta) Date: 2004-12-17 13:50 Message: Logged In: YES user_id=237932 The vsshistory task still produces XML output. I just pointed out that the Ant task only produces text, since Gert asked me to. I would also recommend keeping the Nant vsshistory task's output as XML. We could change the XML schema later if we tought it necessary. The functionality is still there... it wasn't removed. ---------------------------------------------------------------------- Comment By: Felice Vittoria (felicev) Date: 2004-12-17 13:30 Message: Logged In: YES user_id=445334 I'm in FAVOR of having the xml output for several reasons .. one of those being that's what vssdiff produces. Can this funtionality be added back in? ---------------------------------------------------------------------- Comment By: Jay Vilalta (jvilalta) Date: 2004-12-17 11:55 Message: Logged In: YES user_id=237932 Here is the updated vsshistory task file. I've made the changes that Gert requested. I also checked the Ant vsshistory task and verified that it actually only produces text output, not an xml file. I would suggest keeping the output file in xml, although I am open to making changes to xml schema we use for the output. I've removed the old vsshistory file and added the new one. ---------------------------------------------------------------------- Comment By: Jay Vilalta (jvilalta) Date: 2004-12-14 17:11 Message: Logged In: YES user_id=237932 I'll update the properties and attach the modified file. as far a the ANT task goes... I think the output is not XML, but I will verify this as well. ---------------------------------------------------------------------- Comment By: Gert Driesen (drieseng) Date: 2004-12-14 00:07 Message: Logged In: YES user_id=707851 You should use DateTime backed properties for the "fromDate" and "toDate" attributes. The task docs do not mention that an XML file containing the changes is created. Perhaps include a small extract of a generated XML file in the task docs. Also, does the generated XML match that of the Ant vsshistory task ? Can you verify this ? ---------------------------------------------------------------------- Comment By: Gert Driesen (drieseng) Date: 2004-12-09 14:24 Message: Logged In: YES user_id=707851 its on my todo list ;-) ---------------------------------------------------------------------- Comment By: Felice Vittoria (felicev) Date: 2004-12-09 13:31 Message: Logged In: YES user_id=445334 Thanks! I guess now we wait to see if this becomes part of the NantContrib bundle. ---------------------------------------------------------------------- Comment By: Jay Vilalta (jvilalta) Date: 2004-12-09 13:24 Message: Logged In: YES user_id=237932 I've updated the vsshistory file with the suggested changes. The updated file is attached. I have removed the old file as well. ---------------------------------------------------------------------- Comment By: Felice Vittoria (felicev) Date: 2004-12-09 08:20 Message: Logged In: YES user_id=445334 I tried out the vsshistory task and it works great. I have the following comments: 1. In the 'usage' section (HistoryTask.cs) you say that outputFile is needed. However, you have [TaskAttribute ("output", Required=true)] so really output is needed. I would rather have outputFile. Can you make that modification? I never uploaded a file here before. 2. I am going to recommend that this replace vssdiff (that is, deprecate vssdiff). 3. I am also going to recommend that this patch be "promoted" so that it's part of the regular NantContrib bundle. Felice ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=474853&aid=1081451&group_id=54790 ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ _______________________________________________ NAntContrib-Developer mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer